Skip to content

[Merged by Bors] - chore(Combinatorics/SimpleGraph): fix naming of colorable_iff_forall_connectedComponents#41648

Closed
Rida-Hamadani wants to merge 1 commit into
leanprover-community:masterfrom
Rida-Hamadani:connectedComponents
Closed

[Merged by Bors] - chore(Combinatorics/SimpleGraph): fix naming of colorable_iff_forall_connectedComponents#41648
Rida-Hamadani wants to merge 1 commit into
leanprover-community:masterfrom
Rida-Hamadani:connectedComponents

Conversation

@Rida-Hamadani

Copy link
Copy Markdown
Collaborator

Adhering by the naming convention, the connectedComponents in colorable_iff_forall_connectedComponents should be singular.


Open in Gitpod

@Rida-Hamadani Rida-Hamadani added easy < 20s of review time. See the lifecycle page for guidelines. t-combinatorics Combinatorics labels Jul 12, 2026
@github-actions

github-actions Bot commented Jul 12, 2026

Copy link
Copy Markdown

PR summary 84e0778af7

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ colorable_iff_forall_connectedComponent

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 84e0778).

  • +1 new declarations
  • −0 removed declarations
+SimpleGraph.colorable_iff_forall_connectedComponent

No changes to strong technical debt.

No changes to weak technical debt.

Current commit 84e0778af7
Reference commit 4de1b93c21

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@j-loreaux j-loreaux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, thanks

bors merge

@mathlib-bors mathlib-bors Bot added the ready-to-merge This PR has been sent to bors. label Jul 21, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Jul 21, 2026
…_connectedComponents` (#41648)

Adhering by the naming convention, the `connectedComponents` in `colorable_iff_forall_connectedComponents` should be singular.
@mathlib-bors mathlib-bors Bot added the bors-staging This PR is currently being built by bors on the staging branch. label Jul 21, 2026
@mathlib-bors

mathlib-bors Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

@mathlib-bors mathlib-bors Bot changed the title chore(Combinatorics/SimpleGraph): fix naming of colorable_iff_forall_connectedComponents [Merged by Bors] - chore(Combinatorics/SimpleGraph): fix naming of colorable_iff_forall_connectedComponents Jul 21, 2026
@mathlib-bors mathlib-bors Bot closed this Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bors-staging This PR is currently being built by bors on the staging branch. easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-combinatorics Combinatorics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants